Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove the option to bump patch for features pre-major #22

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

saikumarrs
Copy link
Member

Description of the change

Remove the option in the release-please workflow that bumps the patch version even for features before the major version release (as we are still 0.x.x).

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@saikumarrs saikumarrs self-assigned this Dec 12, 2022
@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 3076/3076
🟢 Branches 100% 821/821
🟢 Functions 100% 243/243
🟢 Lines 100% 3076/3076

Test suite run success

68 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 9ded664

@saikumarrs saikumarrs changed the title ci: remove the option to bump path for features before major version release ci: remove the option to bump patch for features before major version release Dec 12, 2022
@saikumarrs saikumarrs changed the title ci: remove the option to bump patch for features before major version release chore(ci): remove the option to bump patch for features pre-major Dec 12, 2022
@saikumarrs saikumarrs merged commit e7b4ed6 into main Dec 12, 2022
@saikumarrs saikumarrs deleted the fix.avoid-patch-bump-for-feat branch December 12, 2022 10:00
@github-actions github-actions bot mentioned this pull request Dec 12, 2022
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants