Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add test-cases for array extraction #30

Merged
merged 1 commit into from
Jun 26, 2023
Merged

chore: add test-cases for array extraction #30

merged 1 commit into from
Jun 26, 2023

Conversation

sanpj2292
Copy link
Contributor

Description of the change

Added test-cases for array extraction, where in

  • The extracted property from a parent array is not present
  • The extracted property in parent array is present
  • The parent array itself is not defined

This PR serves as an example as well that talks about the usage of Array.isArray in json-template-engine

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

chore: add test-cases for array extraction
ab561aa 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
@sanpj2292 sanpj2292 requested a review from koladilip as a code owner June 26, 2023 02:29
@sanpj2292 sanpj2292 self-assigned this Jun 26, 2023
@sanpj2292 sanpj2292 requested review from saikumarrs and a team as code owners June 26, 2023 02:29
@github-actions
Copy link
Contributor

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 3078/3078
🟢 Branches 100% 822/822
🟢 Functions 100% 243/243
🟢 Lines 100% 3078/3078

Test suite run success

73 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from ab561aa

@sanpj2292 sanpj2292 merged commit 7c1ee4b into main Jun 26, 2023
@sanpj2292 sanpj2292 deleted the chore.add-undefined-arr-test-cases branch June 26, 2023 04:58
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

Assignees

@sanpj2292 sanpj2292

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanpj2292 @koladilip