fix: standard function names in generating code #66
Conversation
WalkthroughThe changes introduce a prefix ( Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Coverage report
Test suite run success166 tests passing in 4 suites. Report generated by 🧪jest coverage report action from 9cd5c72 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 10 14 +4
Lines 3078 4565 +1487
Branches 726 1079 +353
===========================================
+ Hits 3078 4565 +1487 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/operators.ts (3 hunks)
- src/translator.ts (1 hunks)
- test/scenarios/standard_functions/template.jt (2 hunks)
Additional comments not posted (3)
test/scenarios/standard_functions/template.jt (1)
3-3: Verify the usage ofkeysto ensure it aligns with the new implementation.src/operators.ts (1)
Line range hint
123-182: Ensure all calls to standard functions use the new prefixed names.Verification successful
The verification process confirms that all calls to the standard functions use the new prefixed names consistently throughout the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all calls to standard functions use the new prefixed names. # Test: Search for the usage of standard functions without the prefix. Expect: No occurrences without the prefix. rg --type js 'function (sum|max|min|avg|length|stddev|first|last|index|keys)\('Length of output: 81
Script:
#!/bin/bash # Description: Verify all calls to standard functions use the new prefixed names. # Test: Search for the usage of standard functions without the prefix in various contexts. # Expect: No occurrences without the prefix. # Search for function calls rg --type js '\b(sum|max|min|avg|length|stddev|first|last|index|keys)\(' # Search for variable assignments rg --type js '\b(sum|max|min|avg|length|stddev|first|last|index|keys)\s*=' # Search for object properties rg --type js '\b(sum|max|min|avg|length|stddev|first|last|index|keys)\s*:'Length of output: 228
src/translator.ts (1)
522-532: Ensure the new function call format withVARS_PREFIXis correctly implemented across all relevant parts of the codebase.
What are the changes introduced in this PR?
if we use standard function names as variables names then it is failing so adding prefix
___while generating code for standard functions codeWhat is the related Linear task?
Resolves INT-2160
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit
Refactor
Bug Fixes
These changes ensure better maintainability and consistency across the codebase.