-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: root mappings #86
Conversation
Warning Review failedThe pull request is closed. WalkthroughThis update includes several key changes across various files in the project. Major updates involve refactoring configurations, improving scenarios, and making TypeScript project adjustments. Specifically, ESLint configuration was updated, TypeScript syntax in files was adjusted, mappings scenarios were restructured, and key dependencies were upgraded. New test cases were added to ensure mapping functionality, and some project configurations were modernized by setting JavaScript language versions and module code generations to ESNext. Changes
Sequence Diagram(s)sequenceDiagram
actor Dev as Developer
participant Config as Configuration Files
participant Tests as Test Files
participant Vite as Vite Config
Dev->>Config: Update .eslintignore to include vite.config.mts
Dev->>Config: Change commitlint.config.js to use module.exports
Dev->>Config: Remove "type": "module" from package.json
Config->>Tests: Update test types and scenarios
Dev->>Tests: Add new mapping scenarios
Dev->>Vite: Update target ESNext and module in tsconfig.json
Dev->>Vite: Change fileName function in vite.config.mts
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Coverage report
Test suite run success170 tests passing in 4 suites. Report generated by 🧪jest coverage report action from 97d95e8 |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 4549 4565 +16
Branches 1076 1082 +6
=========================================
+ Hits 4549 4565 +16 ☔ View full report in Codecov by Sentry. |
What are the changes introduced in this PR?
currently it is not supported when only root mappings are present
What is the related Linear task?
Resolves INT-2160
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit
Chores
.eslintignore
to reflect filename change fromvite.config.ts
tovite.config.mts
.commitlint.config.js
to usemodule.exports
.Dependencies
"type": "module"
frompackage.json
.@commitlint/cli
and@commitlint/config-conventional
versions.New Features
invalid_root_mapping1.json
,invalid_root_mapping2.json
, andonly_root_mapping.json
.Refactor
mappingsPath
instead oftemplatePath
.vite.config.mts
for dynamic filename generation.Scenario
type in tests to replacecontainsMappings
withmappingsPath
.Configuration
tsconfig.json
to targetESNext
for language and module code generation.Tests
processFlatMapping
function to iterate and process mapping parts.