Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sourceConfig issue by changing encoding to Base64.NO_WRAP #221

Merged
merged 1 commit into from
May 17, 2023
Merged

fix: sourceConfig issue by changing encoding to Base64.NO_WRAP #221

merged 1 commit into from
May 17, 2023

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented May 17, 2023 •
edited
Loading

  • Fix sourceConfig fetching issue which is caused because a newline is getting inserted on some devices due to the encoding mechanism we currently use. So we planned to fix that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@1abhishekpandey 1abhishekpandey merged commit 4d9cba1 into develop May 17, 2023
@1abhishekpandey 1abhishekpandey deleted the fix/sourceConfig branch May 17, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdebs itsdebs itsdebs approved these changes

@pallabmaiti pallabmaiti Awaiting requested review from pallabmaiti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1abhishekpandey @itsdebs