fix: moved db operations to background thread/executor and fixed leaking objects #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsdebs
reviewed
Jun 21, 2023
| } | ||
| }; | ||
| Future future = executor.submit(runnable); | ||
| // Need to perform db operations on a separate thread to support strict mode. | ||
| Future<?> future = Executors.newSingleThreadExecutor().submit(runnable); | ||
| try { | ||
| // todo: shall we add some timeout here ? | ||
| future.get(); |
There was a problem hiding this comment.
since we are not utilising the Future reponse, we might use "executor.execute()"
There was a problem hiding this comment.
yes, we are not using the future's response but we do need to await until the runnable finishes its execution, hence i went with using submit and getting future.
There was a problem hiding this comment.
using executor.execute() now
itsdebs
reviewed
Jun 21, 2023
| @@ -466,11 +455,12 @@ private void deleteStatusColumn(SQLiteDatabase database) { | |||
|
|
|||
| private boolean checkIfStatusColumnExists(SQLiteDatabase database) { | |||
| String checkIfStatusExistsSqlString = "PRAGMA table_info(events)"; | |||
| Cursor allRows = null; | |||
| try { | |||
There was a problem hiding this comment.
I think we can do try with resources for closeables. That's recommended approach
There was a problem hiding this comment.
yes, we can do that, will change it accordingly
itsdebs
reviewed
Jun 21, 2023
core/src/main/java/com/rudderstack/android/sdk/core/DBPersistentManager.java
Outdated
Show resolved
Hide resolved
…ized blocks, catching exceptions at place of generation, using try with resources for auto-closeables
itsdebs
previously approved these changes
Jun 28, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
itsdebs
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Type of change
Checklist: