Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove circular dependency in packages #1973

Merged
merged 4 commits into from
Dec 17, 2024
Merged

fix: remove circular dependency in packages #1973

merged 4 commits into from
Dec 17, 2024

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Dec 16, 2024 •
edited
Loading

PR Description

I've removed the circular dependency from plugins to the core SDK pacakge in the test suite.

  • I've also created mocks for various resources needed for testing.
  • Addressed all the lint issues in the test suites.

Linear task (optional)

https://linear.app/rudderstack/issue/SDK-2777/remove-circular-dependency-bw-core-and-plugins

Cross Browser Tests

Please confirm you have tested for the following browsers:

  • Chrome
  • Firefox
  • IE11

Sanity Suite

  • All sanity suite test cases pass locally

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@saikumarrs saikumarrs self-assigned this Dec 16, 2024
@saikumarrs saikumarrs requested a review from a team as a code owner December 16, 2024 19:15
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.68%. Comparing base (fa3f533) to head (00bf7ca).
Report is 1 commits behind head on hotfix/remove-circular-dependency.

Additional details and impacted files 
@@                          Coverage Diff                          @@
##           hotfix/remove-circular-dependency    #1973      +/-   ##
=====================================================================
- Coverage                              58.29%   57.68%   -0.61%     
=====================================================================
  Files                                    485      485              
  Lines                                  16613    16615       +2     
  Branches                                3351     3335      -16     
=====================================================================
- Hits                                    9685     9585     -100     
- Misses                                  5701     5816     +115     
+ Partials                                1227     1214      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Cookies Utils - Legacy - NPM (ESM) 1.54 KB 1.54 KB (0%) 2 KB ✅
Cookies Utils - Legacy - NPM (CJS) 1.75 KB 1.75 KB (0%) 2 KB ✅
Cookies Utils - Legacy - NPM (UMD) 1.54 KB 1.54 KB (0%) 2 KB ✅
Cookies Utils - Modern - NPM (ESM) 1.17 KB 1.17 KB (0%) 1.5 KB ✅
Cookies Utils - Modern - NPM (CJS) 1.4 KB 1.4 KB (0%) 1.5 KB ✅
Cookies Utils - Modern - NPM (UMD) 1.16 KB 1.16 KB (0%) 1.5 KB ✅
Plugins Module Federation Mapping - Legacy - CDN 332 B 332 B (0%) 512 B ✅
Plugins - Legacy - CDN 15.68 KB 15.68 KB (0%) 16 KB ✅
Plugins Module Federation Mapping - Modern - CDN 331 B 331 B (0%) 512 B ✅
Plugins - Modern - CDN 7.2 KB 7.2 KB (0%) 7.5 KB ✅
Common - No bundling 16.22 KB 16.26 KB (+0.26% ▲) 17.2 KB ✅
Load Snippet 758 B 758 B (0%) 1 KB ✅
Core (v1.1) - NPM (ESM) 30.3 KB 30.3 KB (0%) 32 KB ✅
Core (v1.1) - NPM (CJS) 30.54 KB 30.54 KB (0%) 32 KB ✅
Core (v1.1) - NPM (UMD) 30.4 KB 30.4 KB (0%) 32 KB ✅
Core (Content Script - v1.1) - NPM (ESM) 29.84 KB 29.84 KB (0%) 30.5 KB ✅
Core (Content Script - v1.1) - NPM (CJS) 30.08 KB 30.08 KB (0%) 30.5 KB ✅
Core (Content Script - v1.1) - NPM (UMD) 29.91 KB 29.91 KB (0%) 30 KB ✅
Core - Legacy - CDN 48.8 KB 48.8 KB (0%) 49 KB ✅
Core - Modern - CDN 24.99 KB 24.99 KB (0%) 25.5 KB ✅
Service Worker - Legacy - NPM (ESM) 30.6 KB 30.6 KB (0%) 31 KB ✅
Service Worker - Legacy - NPM (CJS) 30.85 KB 30.85 KB (0%) 31 KB ✅
Service Worker - Legacy - NPM (UMD) 30.64 KB 30.64 KB (0%) 31 KB ✅
Service Worker - Modern - NPM (ESM) 25.75 KB 25.75 KB (0%) 26 KB ✅
Service Worker - Modern - NPM (CJS) 26.01 KB 26.01 KB (0%) 26.5 KB ✅
Service Worker - Modern - NPM (UMD) 25.77 KB 25.77 KB (0%) 26 KB ✅
Core - Legacy - NPM (ESM) 48.63 KB 48.63 KB (0%) 49 KB ✅
Core - Legacy - NPM (CJS) 48.88 KB 48.88 KB (0%) 49 KB ✅
Core - Legacy - NPM (UMD) 48.68 KB 48.68 KB (0%) 49 KB ✅
Core - Modern - NPM (ESM) 24.74 KB 24.74 KB (0%) 25 KB ✅
Core - Modern - NPM (CJS) 24.96 KB 24.96 KB (0%) 25.5 KB ✅
Core - Modern - NPM (UMD) 24.79 KB 24.79 KB (0%) 25 KB ✅
Core (Bundled) - Legacy - NPM (ESM) 48.63 KB 48.63 KB (0%) 49 KB ✅
Core (Bundled) - Legacy - NPM (CJS) 48.96 KB 48.96 KB (0%) 49 KB ✅
Core (Bundled) - Legacy - NPM (UMD) 48.68 KB 48.68 KB (0%) 49 KB ✅
Core (Bundled) - Modern - NPM (ESM) 39.66 KB 39.66 KB (0%) 40 KB ✅
Core (Bundled) - Modern - NPM (CJS) 39.98 KB 39.98 KB (0%) 40.5 KB ✅
Core (Bundled) - Modern - NPM (UMD) 39.68 KB 39.68 KB (0%) 40 KB ✅
Core (Content Script) - Legacy - NPM (ESM) 48.11 KB 48.11 KB (0%) 48.5 KB ✅
Core (Content Script) - Legacy - NPM (CJS) 48.35 KB 48.35 KB (0%) 48.5 KB ✅
Core (Content Script) - Legacy - NPM (UMD) 48.12 KB 48.12 KB (0%) 48.5 KB ✅
Core (Content Script) - Modern - NPM (ESM) 39.21 KB 39.21 KB (0%) 39.5 KB ✅
Core (Content Script) - Modern - NPM (CJS) 39.38 KB 39.38 KB (0%) 40 KB ✅
Core (Content Script) - Modern - NPM (UMD) 39.21 KB 39.21 KB (0%) 39.5 KB ✅
All Integrations - Legacy - CDN 95.08 KB 95.08 KB (0%) 95.3 KB ✅
All Integrations - Modern - CDN 90.32 KB 90.32 KB (0%) 91 KB ✅

@saikumarrs saikumarrs requested a review from a team as a code owner December 17, 2024 05:23
@saikumarrs saikumarrs requested review from utsabc and vinayteki95 and removed request for a team December 17, 2024 05:23
@saikumarrs saikumarrs merged commit e525496 into hotfix/remove-circular-dependency Dec 17, 2024
7 checks passed
@saikumarrs saikumarrs deleted the fix.remove-ciruclar-dependency-sdk-2777 branch December 17, 2024 05:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc Awaiting requested review from utsabc utsabc was automatically assigned from rudderlabs/integrations

@vinayteki95 vinayteki95 Awaiting requested review from vinayteki95 vinayteki95 was automatically assigned from rudderlabs/integrations

Assignees

@saikumarrs saikumarrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saikumarrs