Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use gotestsum for test execution #2586

Merged
merged 1 commit into from
Oct 19, 2022
Merged

chore: use gotestsum for test execution #2586

merged 1 commit into from
Oct 19, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Oct 19, 2022

Description

Running tests with gotestsum simplifies the console's output and makes it easier to identify test failures, since only logs from the failed tests are included.

. (1m43.657s) (coverage: 78.7% of statements)
∅  admin
∅  admin/profiler
∅  app
∅  app/apphandlers
✓  app/cluster (3.591s) (coverage: 71.6% of statements)
✓  app/cluster/state (1.677s) (coverage: 74.3% of statements)
∅  build/wait-for-go
∅  cmd/devtool
∅  cmd/devtool/commands
✓  config (7ms) (coverage: 69.5% of statements)
✓  config/backend-config (16.917s) (coverage: 59.8% of statements)
...

If still, for any reason, the full logs from all tests are required, you may enable debug logging
image

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 43.99% // Head: 43.94% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (23a3b44) compared to base (71c8a15).
Patch has no changes to coverable lines.

❗ Current head 23a3b44 differs from pull request most recent head c01cf11. Consider uploading reports for the commit c01cf11 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2586      +/-   ##
==========================================
- Coverage   43.99%   43.94%   -0.05%     
==========================================
  Files         187      187              
  Lines       39086    39086              
==========================================
- Hits        17197    17178      -19     
- Misses      20808    20827      +19     
  Partials     1081     1081              
Impacted Files Coverage Δ
enterprise/suppress-user/suppressUser.go 80.86% <0.00%> (-1.86%) ⬇️
processor/processor.go 71.23% <0.00%> (-0.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum marked this pull request as ready for review October 19, 2022 08:37
Copy link
Member

@lvrach lvrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I especially like disabling logs by default, it has become to hard to investigate an issue.

Copy link
Contributor

@pChondros pChondros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! tried to see if other tools like GoConvey have similar functionality but they cause more confusion than gain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants