Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't ignore stats middleware template path calculation #2594

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Oct 19, 2022

Description

Fixing a bug where the retrieved RouteMatch template was ignored. Additionally, added the response's status code in the measurement's tags.

Note: added a test to verify correct behaviour

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 44.00% // Head: 44.00% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (136a635) compared to base (09dba21).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 136a635 differs from pull request most recent head c75a034. Consider uploading reports for the commit c75a034 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2594   +/-   ##
=======================================
  Coverage   44.00%   44.00%           
=======================================
  Files         187      187           
  Lines       39086    39101   +15     
=======================================
+ Hits        17198    17208   +10     
- Misses      20807    20813    +6     
+ Partials     1081     1080    -1     
Impacted Files Coverage Δ
middleware/middleware.go 24.13% <0.00%> (-8.43%) ⬇️
warehouse/schema.go 47.82% <0.00%> (-1.16%) ⬇️
enterprise/reporting/reporting.go 9.77% <0.00%> (+1.43%) ⬆️
services/stats/stats.go 90.30% <0.00%> (+1.81%) ⬆️
config/backend-config/namespace_config.go 73.95% <0.00%> (+3.12%) ⬆️
enterprise/reporting/setup.go 52.38% <0.00%> (+14.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum force-pushed the fix.statsMiddleware branch from 130c9af to 5808521 Compare October 19, 2022 13:09
@atzoum atzoum marked this pull request as ready for review October 19, 2022 13:09
@atzoum atzoum force-pushed the fix.statsMiddleware branch from 5808521 to 136a635 Compare October 19, 2022 13:13
@atzoum atzoum force-pushed the fix.statsMiddleware branch from 136a635 to 13c5ea7 Compare October 19, 2022 15:04
@atzoum atzoum requested review from chandumlg and cisse21 October 19, 2022 15:31
@atzoum atzoum force-pushed the fix.statsMiddleware branch from 13c5ea7 to c75a034 Compare October 19, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants