fix: use local variable for workspaceId in stash backup #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/1.3.x #2706 +/- ##
================================================
Coverage ? 45.45%
================================================
Files ? 287
Lines ? 47822
Branches ? 0
================================================
Hits ? 21736
Misses ? 24712
Partials ? 1374 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cisse21
approved these changes
Nov 16, 2022
Merged
atzoum
reviewed
Nov 16, 2022
| @@ -231,7 +231,7 @@ func (st *HandleT) storeErrorsToObjectStorage(jobs []*jobsdb.JobT) (errorJob []E | |||
| prefixes := []string{"rudder-proc-err-logs", time.Now().Format("01-02-2006")} | |||
| uploadOutput, err := errFileUploader.Upload(context.TODO(), outputFile, prefixes...) | |||
| errorJobs = append(errorJobs, ErrorJob{ | |||
| jobs: jobsPerWorkspace[workspaceID], | |||
| jobs: jobsPerWorkspace[wrkId], | |||
There was a problem hiding this comment.
please rename wrkId to workspaceID so that shadowing can protect us everywhere.
for workspaceID, filePath := range dumps {
workspaceID := workspaceID
There was a problem hiding this comment.
Already merged this branch. Should I revert and make this change?
There was a problem hiding this comment.
we can do this change later in master branch.
atzoum
pushed a commit
that referenced
this pull request
Nov 16, 2022
atzoum
pushed a commit
that referenced
this pull request
Nov 16, 2022
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a variable copy inside the goroutine
Notion Ticket
https://www.notion.so/rudderstacks/Fix-stash-backups-1-3-0-922b1b6a556a4379ba52f9c6c0bb14a1
Security