Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jobsdb schema migration not performed against all datasets #2737

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Nov 25, 2022

Description

When a writer jobsdb performed schema migration on its dataset tables, it did it only for the last two.

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 46.63% // Head: 46.81% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (b0fd550) compared to base (88f1ec1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
+ Coverage   46.63%   46.81%   +0.17%     
==========================================
  Files         297      297              
  Lines       48696    48697       +1     
==========================================
+ Hits        22711    22796      +85     
+ Misses      24557    24474      -83     
+ Partials     1428     1427       -1     
Impacted Files Coverage Δ
jobsdb/setup.go 90.69% <100.00%> (+0.22%) ⬆️
jobsdb/jobsdb.go 73.26% <0.00%> (+0.29%) ⬆️
jobsdb/backup.go 76.65% <0.00%> (+0.34%) ⬆️
processor/processor.go 86.40% <0.00%> (+0.41%) ⬆️
warehouse/schema.go 51.42% <0.00%> (+1.14%) ⬆️
config/backend-config/namespace_config.go 70.00% <0.00%> (+3.00%) ⬆️
processor/stash/stash.go 66.66% <0.00%> (+22.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants