Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warehouse sync job queries for snowflake and bigquery #2740

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Nov 28, 2022

Description

We are getting the following error for BQ and SNOWFLAKE destinations for the Async Job Framework.

For BigQuery

ERROR warehouse.bigquery bigquery/bigquery.go:269 BQ: Error running job: googleapi: Error 400: Syntax error: Unexpected string literal "bwh_e_470_edf_7_0547_4_bf_3_b_896_29_cd_08_c_289..." at [1:13], invalidQuery

For Snowflake

000904 (42000): SQL compilation error: error line 2 at position 2
invalid identifier 'CONTEXT_SOURCES_JOB_RUN_ID'

002049 (42601): SQL compilation error: error line 2 at position 32
Bind variable:jobrunid not set.

Notion Ticket

https://www.notion.so/rudderstacks/Async-JOB-Queries-are-failing-with-BigQuery-and-Snowflake-c1edd033a228426eb6d5108311152ddc

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 46.75% // Head: 46.86% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (95fd543) compared to base (6ac8c31).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2740      +/-   ##
==========================================
+ Coverage   46.75%   46.86%   +0.11%     
==========================================
  Files         299      299              
  Lines       49072    49078       +6     
==========================================
+ Hits        22942    23000      +58     
+ Misses      24671    24613      -58     
- Partials     1459     1465       +6     
Impacted Files Coverage Δ
warehouse/bigquery/bigquery.go 1.11% <0.00%> (-0.01%) ⬇️
warehouse/jobs/handlers.go 0.00% <0.00%> (ø)
warehouse/jobs/utils.go 12.82% <ø> (+1.45%) ⬆️
warehouse/snowflake/snowflake.go 0.68% <0.00%> (-0.01%) ⬇️
jobsdb/unionQueryLegacy.go 70.49% <0.00%> (-4.92%) ⬇️
router/manager/manager.go 96.70% <0.00%> (-3.30%) ⬇️
services/db/recovery.go 54.76% <0.00%> (-1.20%) ⬇️
processor/processor.go 85.99% <0.00%> (-0.42%) ⬇️
jobsdb/jobsdb.go 72.96% <0.00%> (+0.12%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@chaitanyapraveen chaitanyapraveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants