-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(processor): added ability for geolocation enrichment during pipeline processing #3866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far, I would take another look once we add tests
a0ebb30
to
f895fa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with some non-blocking comments.
Most important is to avoid t.Setenv
in tests as you have already mentioned.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3866 +/- ##
==========================================
- Coverage 71.50% 71.38% -0.13%
==========================================
Files 369 371 +2
Lines 54226 54473 +247
==========================================
+ Hits 38777 38886 +109
- Misses 13162 13274 +112
- Partials 2287 2313 +26
☔ View full report in Codecov by Sentry. |
49b7c75
to
77ecd98
Compare
9bc533f
to
4567f7e
Compare
Some open ended questions which I might need some help in answering would be @atzoum :
The underlying question is that should we just add lookup to every event regardless of lookup succeeds or failed as it keeps parity on the event level flowing through the system or we prevent any lookup ? |
fb5f282
to
71b2806
Compare
Description
The change is adding a pipeline enricher ( geo enrichment ) when processing gateway jobs for a particular source. Below are sequence of events:
Linear Ticket
Ticket
Security