chore: fix archiver test - inconsistent number of files #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
requested review from
atzoum,
cisse21,
lvrach,
BonapartePC,
fracasula,
achettyiitr and
pChondros
atzoum
reviewed
Sep 21, 2023
archiver/archiver_test.go
Outdated
| @@ -171,7 +171,7 @@ func TestJobsArchival(t *testing.T) { | |||
| fileIter := fm.ListFilesWithPrefix(context.Background(), "", prefix, 20) | |||
| files, err := getAllFileNames(fileIter) | |||
| require.NoError(t, err) | |||
| require.Equal(t, sourcesPerWorkspace[i], len(files)) | |||
| require.LessOrEqual(t, sourcesPerWorkspace[i], len(files)) | |||
There was a problem hiding this comment.
Why is the archiver producing more files than expected in this controlled test?
Sidddddarth
force-pushed
the
chore.archiverTestFix
branch
2 times, most recently
from
7376663
to
362b815
Compare
atzoum
approved these changes
Sep 25, 2023
cisse21
approved these changes
Sep 25, 2023
Sidddddarth
force-pushed
the
chore.archiverTestFix
branch
from
362b815
to
78430f1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3902 +/- ##
==========================================
+ Coverage 69.16% 69.27% +0.10%
==========================================
Files 353 353
Lines 52903 52905 +2
==========================================
+ Hits 36589 36648 +59
+ Misses 13998 13941 -57
Partials 2316 2316
☔ View full report in Codecov by Sentry. |
This was referenced Oct 9, 2023
Closed
This was referenced Oct 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixing a test in archiver, where there could be more files uploaded per source than 1.
Linear Ticket
slack thread
Security