Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the new reloadable config api in reporting #3909

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Sep 25, 2023

Description

Only Event schemas v1 is now left using the old config api, which shall be removed altogether in the next release

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 45.16% and project coverage change: +0.15% 🎉

Comparison is base (01a0737) 69.16% compared to head (fe3c70b) 69.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3909      +/-   ##
==========================================
+ Coverage   69.16%   69.31%   +0.15%     
==========================================
  Files         353      353              
  Lines       52905    52900       -5     
==========================================
+ Hits        36592    36668      +76     
+ Misses      13996    13926      -70     
+ Partials     2317     2306      -11     
Files Changed Coverage Δ
enterprise/reporting/reporting.go 29.91% <41.66%> (-0.09%) ⬇️
enterprise/reporting/error_reporting.go 21.51% <57.14%> (-0.48%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum merged commit 741fd74 into master Sep 25, 2023
35 checks passed
@atzoum atzoum deleted the chore.reportingReloadableCfg branch September 25, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants