Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: omit failedMessages from reporting json object #3936

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Oct 3, 2023

Description

Reporting http api doesn't expect a failedMessages field in the payload.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum force-pushed the chore.reportingFailedMessagesField branch from 872708f to 97c31ba Compare October 3, 2023 06:34
@atzoum atzoum changed the title chore: omit empty failedMessages in reporting json object chore: omit failedMessages from reporting json object Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1fcabdd) 70.20% compared to head (97c31ba) 70.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3936      +/-   ##
==========================================
+ Coverage   70.20%   70.38%   +0.17%     
==========================================
  Files         357      357              
  Lines       53160    53160              
==========================================
+ Hits        37321    37416      +95     
+ Misses      13585    13508      -77     
+ Partials     2254     2236      -18     
Files Coverage Δ
utils/types/reporting_types.go 90.00% <ø> (ø)

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth merged commit 0969b31 into master Oct 3, 2023
37 checks passed
@Sidddddarth Sidddddarth deleted the chore.reportingFailedMessagesField branch October 3, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants