Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use common PAT instead of rudder-server-bot #3952

Merged

Conversation

lvrach
Copy link
Member

@lvrach lvrach commented Oct 9, 2023

Description

secrets.GH_PAT is using rudder-server-bot Personal Access Token. We want to remove the rudder-server-bot account and instead use secrets.PAT, already used in other Github actions

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-388/remove-rudder-server-bot-account-from-github

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@lvrach lvrach marked this pull request as ready for review October 9, 2023 14:51
@lvrach lvrach requested review from atzoum and cisse21 October 9, 2023 15:16
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5f3820f) 70.38% compared to head (eb59771) 70.48%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3952      +/-   ##
==========================================
+ Coverage   70.38%   70.48%   +0.09%     
==========================================
  Files         357      357              
  Lines       53646    53646              
==========================================
+ Hits        37758    37810      +52     
+ Misses      13620    13571      -49     
+ Partials     2268     2265       -3     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit 08d036e into master Oct 9, 2023
35 checks passed
@cisse21 cisse21 deleted the fix/pipe-388-remove-rudder-server-bot-account-from-github branch October 9, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants