Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable errcheck and unparam linters for warehouse #3970

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Oct 12, 2023

Description

  • Enable errcheck and unparam linters for warehouse package. (PIPE-410)

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr changed the title chore: enable errcheck and unparam for warehouse chore: enable errcheck and unparam linters for warehouse Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (19ca0f6) 70.52% compared to head (d78df76) 70.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3970      +/-   ##
==========================================
- Coverage   70.52%   70.50%   -0.02%     
==========================================
  Files         357      357              
  Lines       53673    53663      -10     
==========================================
- Hits        37851    37837      -14     
+ Misses      13566    13564       -2     
- Partials     2256     2262       +6     
Files Coverage Δ
...ehouse/integrations/azure-synapse/azure-synapse.go 77.20% <100.00%> (+0.15%) ⬆️
warehouse/identity/identity.go 66.18% <80.00%> (ø)
warehouse/integrations/mssql/mssql.go 77.03% <50.00%> (+0.04%) ⬆️
warehouse/integrations/redshift/redshift.go 74.03% <50.00%> (+0.02%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit d99967f into master Oct 12, 2023
43 of 44 checks passed
@achettyiitr achettyiitr deleted the chore.warheouse-linters-cleanup branch October 12, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants