Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix remove warehouse jobs panic #3982

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Oct 17, 2023

Description

Fixes PIPE-421 : Removes panics from warehouse jobs module

Linear Ticket

Linear Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (dd457e4) 71.14% compared to head (1c3d045) 71.11%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3982      +/-   ##
==========================================
- Coverage   71.14%   71.11%   -0.03%     
==========================================
  Files         368      368              
  Lines       54049    54083      +34     
==========================================
+ Hits        38454    38463       +9     
- Misses      13307    13327      +20     
- Partials     2288     2293       +5     
Files Coverage Δ
router/handle.go 71.36% <100.00%> (-0.07%) ⬇️
router/types/types.go 91.11% <ø> (ø)
warehouse/integrations/bigquery/bigquery.go 64.37% <100.00%> (-0.04%) ⬇️
warehouse/internal/mocks/utils/mock_uploader.go 86.17% <100.00%> (+0.11%) ⬆️
warehouse/utils/utils.go 82.00% <ø> (ø)
warehouse/jobs/jobs.go 7.69% <0.00%> (ø)
warehouse/validations/validate.go 81.26% <0.00%> (ø)
warehouse/integrations/redshift/redshift.go 73.85% <50.00%> (-0.19%) ⬇️
...nternal/service/loadfiles/downloader/downloader.go 79.77% <25.00%> (-2.79%) ⬇️
warehouse/router/upload.go 71.94% <28.57%> (-0.65%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit 6e0729c into master Oct 17, 2023
35 checks passed
@cisse21 cisse21 deleted the chore.warehousePanicFix branch October 17, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants