Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: flaky error index report test #3988

Merged
merged 1 commit into from
Oct 18, 2023
Merged

chore: flaky error index report test #3988

merged 1 commit into from
Oct 18, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Oct 18, 2023 •
edited
Loading

Description

  • Since we can't have 2 jobsDB for reading, using existing eir.errIndexDB

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6e0729c) 71.07% compared to head (1f769e6) 71.10%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3988      +/-   ##
==========================================
+ Coverage   71.07%   71.10%   +0.02%     
==========================================
  Files         368      368              
  Lines       54083    54083              
==========================================
+ Hits        38441    38455      +14     
+ Misses      13343    13332      -11     
+ Partials     2299     2296       -3

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit 9b7157f into master Oct 18, 2023
39 of 40 checks passed
@achettyiitr achettyiitr deleted the chore.flaky-report-test branch October 18, 2023 10:10
fracasula pushed a commit that referenced this pull request Oct 19, 2023
@achettyiitr @fracasula
chore: flaky error index report test (#3988)
2b5e78f
This was referenced Oct 30, 2023
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atzoum atzoum atzoum approved these changes

@cisse21 cisse21 cisse21 approved these changes

@fracasula fracasula Awaiting requested review from fracasula

@abhimanyubabbar abhimanyubabbar Awaiting requested review from abhimanyubabbar

@Sidddddarth Sidddddarth Awaiting requested review from Sidddddarth

Assignees
No one assigned
Labels
server-team with tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achettyiitr @atzoum @cisse21