feat: introducing chi middleware for warehouse #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
force-pushed
the
feat.http-middleware
branch
from
bba315a
to
d3ab551
Compare
fracasula
approved these changes
Oct 25, 2023
| @@ -127,6 +129,9 @@ func NewApi( | |||
|
|
|||
| func (a *Api) Start(ctx context.Context) error { | |||
| srvMux := chi.NewRouter() | |||
| srvMux.Use( | |||
| chiware.StatMiddleware(ctx, srvMux, a.statsFactory, "warehouse"), | |||
There was a problem hiding this comment.
The 2nd argument doesn't seem to be used internally, @atzoum can we remove it from the kit?
There was a problem hiding this comment.
Good catch @fracasula . Middleware doesn't need to have access to the router.
There was a problem hiding this comment.
achettyiitr
force-pushed
the
feat.http-middleware
branch
from
d3ab551
to
4bde439
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4010 +/- ##
=======================================
Coverage 71.39% 71.39%
=======================================
Files 371 371
Lines 54472 54475 +3
=======================================
+ Hits 38889 38895 +6
+ Misses 13270 13267 -3
Partials 2313 2313
☔ View full report in Codecov by Sentry. |
lvrach
approved these changes
Oct 26, 2023
This was referenced Oct 30, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear Ticket
Security