Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace golang.org/x/exp/slices to slices #4031

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Oct 30, 2023

Description

clean up golang.org/x/exp/slices to slices
Fixes PIPE-457

Linear Ticket

Linear Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (554a04a) 71.49% compared to head (39336a3) 71.47%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4031      +/-   ##
==========================================
- Coverage   71.49%   71.47%   -0.03%     
==========================================
  Files         370      370              
  Lines       54614    54632      +18     
==========================================
+ Hits        39046    39047       +1     
- Misses      13246    13258      +12     
- Partials     2322     2327       +5     
Files Coverage Δ
controlplane/controlplane.go 63.41% <100.00%> (ø)
controlplane/manager.go 66.66% <ø> (ø)
enterprise/reporting/reporting.go 44.42% <ø> (ø)
gateway/webhook/webhook.go 60.12% <ø> (ø)
jobsdb/internal/cache/cache.go 98.50% <ø> (ø)
jobsdb/jobsdb.go 73.31% <ø> (-0.15%) ⬇️
processor/eventfilter/eventfilter.go 92.07% <ø> (ø)
processor/processor.go 88.52% <ø> (ø)
router/batchrouter/handle.go 62.25% <ø> (ø)
router/batchrouter/handle_async.go 8.62% <ø> (ø)
... and 25 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit f014c01 into master Oct 30, 2023
37 checks passed
@cisse21 cisse21 deleted the chore.replaceExpWithSlices branch October 30, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants