Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor scheduler cleanup #4032

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

achettyiitr
Copy link
Member

Description

  • Avoid using globals (scheduledTimesCache, StartUploadAlways)

Linear Ticket

  • Resolves PIPE-458

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (554a04a) 71.49% compared to head (75cc9f2) 71.41%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4032      +/-   ##
==========================================
- Coverage   71.49%   71.41%   -0.08%     
==========================================
  Files         370      370              
  Lines       54614    54634      +20     
==========================================
- Hits        39046    39018      -28     
- Misses      13246    13293      +47     
- Partials     2322     2323       +1     
Files Coverage Δ
controlplane/controlplane.go 63.41% <100.00%> (ø)
controlplane/manager.go 66.66% <ø> (ø)
enterprise/reporting/reporting.go 44.42% <ø> (ø)
gateway/webhook/webhook.go 60.12% <ø> (ø)
jobsdb/internal/cache/cache.go 98.50% <ø> (ø)
jobsdb/jobsdb.go 73.17% <ø> (-0.29%) ⬇️
processor/eventfilter/eventfilter.go 92.07% <ø> (ø)
processor/processor.go 88.52% <ø> (ø)
router/batchrouter/handle.go 62.25% <ø> (ø)
router/batchrouter/handle_async.go 8.62% <ø> (ø)
... and 27 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fracasula fracasula merged commit 2cc9470 into master Oct 30, 2023
35 checks passed
@fracasula fracasula deleted the refactor.scheduler-cleanup branch October 30, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants