Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor tunneling cleanup #4034

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Oct 30, 2023

Description

  • Avoid exposing unexported methods.
  • Added test cases.
  • Moved to the /warehouse/integrations package as it is meant to be used for integrations only ATM.

Linear Ticket

  • Resolves PIPE-459

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bd855f6) 71.43% compared to head (8047d5e) 71.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4034      +/-   ##
==========================================
+ Coverage   71.43%   71.45%   +0.01%     
==========================================
  Files         370      370              
  Lines       54632    54633       +1     
==========================================
+ Hits        39028    39036       +8     
+ Misses      13285    13279       -6     
+ Partials     2319     2318       -1     
Files Coverage Δ
warehouse/integrations/postgres/postgres.go 75.90% <100.00%> (ø)
warehouse/utils/utils.go 81.74% <ø> (-0.27%) ⬇️
warehouse/integrations/redshift/redshift.go 73.85% <50.00%> (ø)
warehouse/integrations/tunnelling/connect.go 94.73% <89.28%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fracasula fracasula merged commit 877eb70 into master Oct 30, 2023
35 checks passed
@fracasula fracasula deleted the refactor.tunneling-cleanup branch October 30, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants