Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: state for uploads #4057

Merged
merged 8 commits into from
Nov 6, 2023
Merged

chore: state for uploads #4057

merged 8 commits into from
Nov 6, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Oct 31, 2023

Description

  • Initial efforts to break the uploads file into smaller chunks so that it would be easier to review and understand the code.
  • Some feedback around it in here.
  • Note: There is no change from the existing code.
  • There is a follow-up chore: split state machine #4058

Linear Ticket

  • Resolves PIPE-466

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6583364) 71.78% compared to head (527b6fd) 71.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4057      +/-   ##
==========================================
+ Coverage   71.78%   71.82%   +0.04%     
==========================================
  Files         372      373       +1     
  Lines       54984    54982       -2     
==========================================
+ Hits        39472    39493      +21     
+ Misses      13187    13171      -16     
+ Partials     2325     2318       -7     
Files Coverage Δ
warehouse/router/state.go 100.00% <100.00%> (ø)
warehouse/router/upload.go 70.85% <100.00%> (-0.91%) ⬇️
warehouse/router/identities.go 19.83% <0.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

warehouse/router/state.go Outdated Show resolved Hide resolved
@cisse21 cisse21 merged commit 898aa09 into master Nov 6, 2023
35 checks passed
@cisse21 cisse21 deleted the chore.uploads-state branch November 6, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants