Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove workspace ack in multitenant setup [PIPE-474] #4066

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

BonapartePC
Copy link
Contributor

@BonapartePC BonapartePC commented Nov 1, 2023

Description

remove workspace ack in multitenant setup since server serves all the workspaces not just workspaces from scheduler

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-474/cleanup-workspaces-ack-code-from-server

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@BonapartePC BonapartePC changed the title chore: remove workspace ack in multitenant setup chore: remove workspace ack in multitenant setup [PIPE-474] Nov 1, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6583364) 71.78% compared to head (e4d9b6d) 71.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4066      +/-   ##
==========================================
+ Coverage   71.78%   71.80%   +0.01%     
==========================================
  Files         372      371       -1     
  Lines       54984    54858     -126     
==========================================
- Hits        39472    39392      -80     
+ Misses      13187    13153      -34     
+ Partials     2325     2313      -12     
Files Coverage Δ
app/cluster/dynamic.go 53.20% <ø> (-1.44%) ⬇️
app/cluster/state/etcd.go 57.57% <ø> (-5.89%) ⬇️
app/cluster/state/static.go 100.00% <ø> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth merged commit 338a8e9 into master Nov 6, 2023
35 checks passed
@Sidddddarth Sidddddarth deleted the chore.removeWorkspaceCode branch November 6, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants