Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook source transformation failed with error: cannot find module #4120

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Nov 13, 2023

Description

Source type should be set to lowercase while constructing the webhook url. Introduced by #4007
Adding an integration test to guard against a future regression.

Linear Ticket

Fixes PIPE-522

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f95fa51) 71.99% compared to head (3d02fc3) 72.33%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4120      +/-   ##
==========================================
+ Coverage   71.99%   72.33%   +0.33%     
==========================================
  Files         377      383       +6     
  Lines       55223    55243      +20     
==========================================
+ Hits        39760    39962     +202     
+ Misses      13142    12951     -191     
- Partials     2321     2330       +9     
Files Coverage Δ
gateway/webhook/webhookTransformer.go 72.04% <100.00%> (ø)
testhelper/backendconfigtest/source_builder.go 86.66% <100.00%> (+2.05%) ⬆️

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum merged commit f4686aa into master Nov 13, 2023
35 checks passed
@atzoum atzoum deleted the fix.webhook branch November 13, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants