-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboarding lytics bulk upload #5000
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5000 +/- ##
==========================================
- Coverage 74.65% 74.58% -0.08%
==========================================
Files 430 436 +6
Lines 50144 50387 +243
==========================================
+ Hits 37436 37580 +144
- Misses 10230 10315 +85
- Partials 2478 2492 +14 ☔ View full report in Codecov by Sentry. |
router/batchrouter/asyncdestinationmanager/lytics_bulk_upload/lyticsBulkUpload.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/lytics_bulk_upload/testdata/intialUploadFile.csv
Outdated
Show resolved
Hide resolved
when there is no poll then use SimpleAsyncDestinationManager |
Used it |
return body, res.StatusCode, err | ||
} | ||
|
||
func (e *LyticsBulkUploader) UploadBulkFile(data *HttpRequestData, filePath string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func (e *LyticsBulkUploader) -> func (u *LyticsBulkUploader)
the last word is the most relevant uploader
same for all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
router/batchrouter/asyncdestinationmanager/lytics_bulk_upload/lyticsBulkUpload.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/lytics_bulk_upload/lyticsBulkUpload.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/lytics_bulk_upload/lytics_test.go
Outdated
Show resolved
Hide resolved
BulkApi string | ||
} | ||
|
||
func (u *LyticsServiceImpl) getBulkApi(destConfig DestinationConfig) *LyticsServiceImpl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func (u *LyticsServiceImpl) -> func (*LyticsServiceImpl)
return common.GetMarshalledData(string(job.EventPayload), job.JobID) | ||
} | ||
|
||
func (u *LyticsServiceImpl) MakeHTTPRequest(data *HttpRequestData) ([]byte, int, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func (u *LyticsServiceImpl) -> func (s *LyticsServiceImpl) same for rest
Description
< Replace with adequate description for this PR as per Pull Request document >
Linear Ticket
Resolvs INT-1984
Security