-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error reporting lag and pii handle #5028
Conversation
- introduce a lag metric in error detail reporting - use ui configuration while storing sample event in error detail reports
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5028 +/- ##
==========================================
+ Coverage 74.67% 74.76% +0.09%
==========================================
Files 435 435
Lines 50384 50418 +34
==========================================
+ Hits 37622 37693 +71
+ Misses 10283 10235 -48
- Partials 2479 2490 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some tests on when reporting is enabled and when it is disabled?
Tests have been added. Can you check & let me know ? |
…ching report data - store last reported time as the main loop start time when no rows are returned
@satishrudderstack , can you look into this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
There is a recursive payload that is trying to get stored into
error_detail_reports
table. Since the payload is large and recursive in nature, we are having difficulty in reading it from postgres which is causing delays.For now, we are planning two things
error_detail_reports
table as it was not storing sample responses. Recently we started storing it. We are planning to respect this configuration forerror_detail_reports
table as well.Linear Ticket
Resolves INT-2582
Security