fix: error reporting lag and pii handle

[sanpj2292]

Description

There is a recursive payload that is trying to get stored into error_detail_reports table. Since the payload is large and recursive in nature, we are having difficulty in reading it from postgres which is causing delays.

For now, we are planning two things

1. Introduce a lag metric, have an alert configured on it whenever such a delay happens(while trying to fetch data from postgres)
2. For not storing sample response, we have a configuration in rudderstack UI which was not being used for error_detail_reports table as it was not storing sample responses. Recently we started storing it. We are planning to respect this configuration for error_detail_reports table as well.

Linear Ticket

Resolves INT-2582

Security

• The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 6.89655% with 81 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (63c4033) to head (6dc8edd).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
enterprise/reporting/error_reporting.go	6.89%	81 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5028      +/-   ##
==========================================
+ Coverage   74.67%   74.76%   +0.09%     
==========================================
  Files         435      435              
  Lines       50384    50418      +34     
==========================================
+ Hits        37622    37693      +71     
+ Misses      10283    10235      -48     
- Partials     2479     2490      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mihir20]

Can we add some tests on when reporting is enabled and when it is disabled?

[sanpj2292]

Can we add some tests on when reporting is enabled and when it is disabled?

Tests have been added. Can you check & let me know ?

[ktgowtham]

@satishrudderstack , can you look into this PR?

[mihir20]

LGTM

[itsmihir]

LGTM