-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update router reports payload behind a flag, emit stats to observe sizes #5067
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5067 +/- ##
==========================================
- Coverage 74.74% 74.74% -0.01%
==========================================
Files 435 435
Lines 50384 50394 +10
==========================================
+ Hits 37662 37668 +6
- Misses 10244 10245 +1
- Partials 2478 2481 +3 ☔ View full report in Codecov by Sentry. |
router/worker.go
Outdated
} | ||
stats.Default.NewTaggedStat("router_transformation_payload_size_bytes", stats.HistogramType, tags).Observe(float64(len(destinationJobMetadata.JobT.EventPayload))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need router_transformation_payload_size_bytes
? Also it's router input payload rt. If we're planning to capture, may be capture at early stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we don't need to capture this multiple times for each router job. We can capture this once per destinationJob.
router/worker.go
Outdated
@@ -1012,6 +1016,16 @@ func (w *worker) postStatusOnResponseQ(respStatusCode int, payload json.RawMessa | |||
} | |||
return | |||
} | |||
switch errorAt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add additional check of status code and set only if it's failed. just as a safe check. even though this function gets returned if it's success before this block
Description
Emit stats to observe payload sizes:
Puts behaviour from #4999 behind a feature flag(default behaviour is to send jobsdb payload for now)
Adds a
payloadStage
field to error response field in the job status.Linear Ticket
Resolves PIPE-1504
Security