Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: trim eventNames sent to reporting if length exceeds 50 characters #5171

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

vamsikrishnakandi
Copy link
Contributor

Description

Trimming eventName being sent to reporting if length exceeds 50 characters

Tested with 你好世界😊 Привет мир 🌍 ¡Hola, mundo! こんにちは世界 안녕하세요 세계 नमस्ते दुनिया مرحبا بالعالم 😊🌎

Linear Ticket

Completes OBS-670

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.87%. Comparing base (29efe26) to head (5971052).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
enterprise/reporting/reporting.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5171      +/-   ##
==========================================
- Coverage   72.96%   72.87%   -0.10%     
==========================================
  Files         439      439              
  Lines       51165    51165              
==========================================
- Hits        37335    37285      -50     
- Misses      11374    11419      +45     
- Partials     2456     2461       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit 87283c4 into master Oct 4, 2024
57 checks passed
@cisse21 cisse21 deleted the chore.event-name-limit2 branch October 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants