Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clickhouse temporary files deletion happening twice #5182

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

achettyiitr
Copy link
Member

Description

  • Since we are already calling misc.RemoveFilePaths around LoadFileDownloader.Download, we don't need to call it again.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.01%. Comparing base (72443b2) to head (44c9c92).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5182      +/-   ##
==========================================
+ Coverage   72.91%   73.01%   +0.10%     
==========================================
  Files         439      439              
  Lines       51134    51131       -3     
==========================================
+ Hits        37282    37332      +50     
+ Misses      11390    11342      -48     
+ Partials     2462     2457       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit 9f52106 into master Oct 9, 2024
58 checks passed
@cisse21 cisse21 deleted the fix.clickhouse-file-remove branch October 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants