Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM2 regression: missing clips/parts/images/animations #3828

Closed
torokati44 opened this issue Mar 28, 2021 · 5 comments
Closed

AVM2 regression: missing clips/parts/images/animations #3828

torokati44 opened this issue Mar 28, 2021 · 5 comments
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working

Comments

@torokati44
Copy link
Member

There was a regression with https://z0r.de/6483 (SWF) a few weeks ago.
Yes, it's AVM2, but it used to work well before.

On a912735 the walking robot animation appears to work fine.
Then on the next commit, 5054651 it just disappears after the first frame, outputting lines like:

[2021-03-28T14:15:30Z ERROR ruffle_core::library] Tried to instantiate non-registered character ID 1
[2021-03-28T14:15:30Z ERROR ruffle_core::display_object::movie_clip] Unable to instantiate display node id 1

and:

[2021-03-28T14:15:32Z ERROR ruffle_core::display_object::container] Encountered AVM2 error when dispatching event: TypeError: undefined is not an Object

And on the commit after that, a2d5601, the result is the same, but the second kind of error is not printed anymore.
This is also what happens on current master.

These commits were merged as part of #3177.

@torokati44 torokati44 added the bug Something isn't working label Mar 28, 2021
@torokati44 torokati44 changed the title AVM2 regression on z0r.de/6483 - Tried to instantiate non-registered character, Unable to instantiate display node AVM2 regression on z0r.de/6483 Mar 28, 2021
@torokati44 torokati44 added the A-avm2 Area: AVM2 (ActionScript 3) label Mar 28, 2021
@kmeisthax
Copy link
Member

Weirdly, I don't get the error message anymore, but I still don't see the robot appear.

The file has no DoABC so this is purely a consequence of changing the timeline order-of-events in AVM2. Some time after this bug was filed the non-registered character error went away (as far as I can tell) so now nothing is yielding any errors...

@torokati44 torokati44 changed the title AVM2 regression on z0r.de/6483 AVM2 regression on z0r.de/6483 and z0r.de/5003 Apr 13, 2021
@torokati44
Copy link
Member Author

A very similar thing happens, across the same mentioned commits, with the mountains in the background of https://z0r.de/5003 (SWF).

@sombraguerrero
Copy link
Contributor

animals_as3.zip
A small but varied collection of really simple AS3 animations I use in my test bed. They have all fallen victim to these regressions in one manifestation or another.

@torokati44 torokati44 changed the title AVM2 regression on z0r.de/6483 and z0r.de/5003 AVM2 regression: missing clips/parts/images/animations Apr 20, 2021
@torokati44
Copy link
Member Author

Since then, https://z0r.de/5003 has regressed further: now the grass in the foreground also disappears.
I'm also getting an error about a getBounds() method not being found.

@torokati44
Copy link
Member Author

Looks like #7570 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants