-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpak Support #9220
Comments
Error
DiggingThis line is the reason for the first message, as far as I am aware this should be harmless. In arboard, this line implements the This line in wl-clipboard-rs determines if there is a clipboard supported or not. And at this point, I reach the end of my knowledge. |
Clipboard crash is just missing permissions iirc. A good test would be to download Flatseal and enable all the permissions and see if it still crashes. The SVG logo isn't required but highly encouraged, same thing with Desktop/metainfo file being upstreamed but it can be in your Flatpak repo. The only thing that is 100% required when submitting to Flathub is you have permission from the ruffle-rs maintainers |
Apologies, I doubt that the issue is with permissions. Please do follow the mention hole with YaLTeR/wl-clipboard-rs#32 to see. It seems it might be improper usage of libraries. Specifically flatpak support might have to wait on rust-windowing/winit#2156 for proper clipboard handling.
That is why I am here :D |
One solution is to allow Clipboard to become null, and simply warn in console that it will not operate. But I despise this type of hacky solution and would ruin user experience. |
I understand that the suggestion is to use Smithay Clipboard, but this is not a cross-platform library like arboard, and I'm not sure the Ruffle devs would want to add this additional dependency. Anyway @Doomsdayrs thanks for your work on this! Here's the Ruffle icon SVG: |
It can be done via abstraction. Using a separate library for Linux while retaining the current library for other platforms. In fact, the abstraction would be quite simple as the clipboard is only used in two lines of code.
Where is this file hosted on the github? Since I rather have it included upstream. |
I don't think it is. One of the other Ruffle developers sent me this file on Discord. I do think it would be a good idea to include it in the repo somewhere though. |
Would love to see a Flatpak or an AppImage supported, as on readonly systems like SteamOS, we are missing libraries to run it: ./ruffle: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory |
Sorry for the late reply. |
Alright, Now using the Congrats to the new UI, Looks much better! The issue with the clipboard still seems present. To update, @YaLTeR from To summarize, GUI apps should be using the wayland offer, which should be in @YaLTeR suggests smithay-clipboard, but that seems a bit unmaintained and is not cross-platform. I personally want to say clipboard should be disabled on flatpak & wayland until proper support is added, but I believe that might be contrary to the goals Ruffle has currently. |
It isn't, but it is recommended, especially if there are problems that need to be solved in up-stream. |
We are now officially available on Flathub: https://flathub.org/apps/rs.ruffle.Ruffle 🎉 Thank you to all the contributors, especially @Doomsdayrs ! |
TL;DR Status: the current Flathub submission:
Describe the feature
While ruffle is still in active development and not yet stable, it is still quite useful for users to play many flash games (such as BTD) that do operate well with the current support.
To make it easier for users on Linux distributions to use Ruffle, it would be nice to get ruffle bundled with flatpak and published to flathub.
This repository contains my current bundling of ruffle. There are issues I want to first solve before I can submit to flathub, of course with permission from ruffle-rs to do so.
Issues
Most of these are all XDG compliance related.
These are some requirements I would like to get put upstream.
The text was updated successfully, but these errors were encountered: