Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Papas Scooperia: Property drawWithQuality not found on flash.display.BitmapData #9541

Closed
Tracked by #9201
MartySVK opened this issue Feb 12, 2023 · 0 comments · Fixed by #9591
Closed
Tracked by #9201

Papas Scooperia: Property drawWithQuality not found on flash.display.BitmapData #9541

MartySVK opened this issue Feb 12, 2023 · 0 comments · Fixed by #9591
Labels
A-avm2 Area: AVM2 (ActionScript 3) A-rendering Area: Rendering & Graphics bug Something isn't working unimplemented Issues for functionality that hasn't been implemented yet

Comments

@MartySVK
Copy link
Contributor

Describe the bug

Papa's Scooperia is missing unimplemented BitmapData.drawWithQuality

Expected behavior

Due to documentation (https://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/display/BitmapData.html#drawWithQuality()) BitmapData.drawWithQuality is the same as BitmapData.draw but with quality parameter.
It should be easy to just copy the implementation of BitmapData.draw or maybe implement quality settings thanks to @Dinnerbone's PR #9400

Affected platform

Online demo

Operating system

Windows 10

Browser

Chrome 109

Additional information

No response
@MartySVK MartySVK added the bug Something isn't working label Feb 12, 2023
@MartySVK MartySVK mentioned this issue Feb 12, 2023
Closed
17 tasks
@Lord-McSweeney Lord-McSweeney added unimplemented Issues for functionality that hasn't been implemented yet A-avm2 Area: AVM2 (ActionScript 3) labels Feb 12, 2023
@n0samu n0samu added the A-rendering Area: Rendering & Graphics label Feb 13, 2023
@Dinnerbone Dinnerbone mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-avm2 Area: AVM2 (ActionScript 3) A-rendering Area: Rendering & Graphics bug Something isn't working unimplemented Issues for functionality that hasn't been implemented yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avm2: Implement BitmapData.drawWithQuality Dinnerbone/ruffle
3 participants
@MartySVK @n0samu @Lord-McSweeney