Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure/Refactor files (translations, common functions) #37

Open
rugk opened this issue Sep 29, 2017 · 1 comment
Open

Restructure/Refactor files (translations, common functions) #37

rugk opened this issue Sep 29, 2017 · 1 comment
Labels
discuss me

Comments

@rugk
Copy link
Owner

rugk commented Sep 29, 2017

For translations extra files would be useful. (maybe a dir like translations/de-DE.sh)

And when we are at it, we could also put functions into a file, which can be load by many other scripts. This would possibly also be useful for #32 and we could reduce code duplication (in borgcron.sh and borgcron_starter.sh).
A file like commons.sh or functions.sh could then also be loaded by unit tests, which makes testing easier…
@rugk
Copy link
Owner Author

rugk commented Nov 21, 2017

Probably this needs a general overhaul and more modular structure. Not everyone will be using the notifications e.g. 🤔

@rugk rugk changed the title Restructure files (translations, common functions) Restructure/Refactor files (translations, common functions) Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss me
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rugk