Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting the Return key causes the Mastodon accounr settings to clear (reloading the setting) #110

Open
ELLIOTTCABLE opened this issue May 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ELLIOTTCABLE
Copy link

Bug description

When attempting to enter my account in the settings, the yellow message disappears, which implies something has worked:

Screenshot 2023-05-23 at 12 01 11

However, hitting the Return key causes the field to clear — so does reloading the settings.

I can't seem to find a way to actually set, and save, my username. 😅

System

Operating system and version: macOS Ventura 13.4
Browser and version: Firefox 113.0.1
Add-on version: 2.0

@ELLIOTTCABLE ELLIOTTCABLE added the bug Something isn't working label May 23, 2023
@rugk rugk changed the title Unable to enter account-name Hitting the Return key causes the Mastodon accounr settings to clear (reloading the setting) May 30, 2023
@rugk
Copy link
Owner

rugk commented May 30, 2023

Hi and thanks for your report.

I guess the important point is this:

However, hitting the Return key causes the field to clear — so does reloading the settings.

Because actually, you do not need to hit enter in any way. It automatically saves all settings, so if there is no error you can expect it works.

I tried to reproduce this issue on Linux (GNOME) and when I hit enter things just flash a bit, but the setting stays there.
However, this could be related to that you use macOS… maybe you have the "Reset all settings button" button focused all the time/enter causes it to be triggered, even though you are editing a completely different field?

In any case that behavior is of course not wanted, but I guess I need people with macOS experience/who can test this to have a reliable fix.

@rugk
Copy link
Owner

rugk commented May 30, 2023

Technical note: The reset button HTML code is here and it type="button", not type="submit" (which it would also be when you leave that out given crazy HTML defaults 🙃), so actually it should not be triggered:

https://github.com/rugk/mastodon-simplified-federation/blob/2e320d4ca3140808ec684cff0160732ac25f2f69/src/options/options.html#LL93C4-L93C4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants