Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine SVG and Canvas generation method #188

Closed
fregante opened this issue Apr 25, 2019 · 7 comments · Fixed by #215
Closed

Combine SVG and Canvas generation method #188

fregante opened this issue Apr 25, 2019 · 7 comments · Fixed by #215
Labels
blocked This issue is blocked by something from the outside and cannot be done currently.
Milestone
v1.7

Comments

@fregante
Copy link

fregante commented Apr 25, 2019 •
edited
Loading

.
@rugk
Copy link
Owner

rugk commented Apr 25, 2019

So your idea is: Display as an SVG always, for export optionally convert it?

This would indeed simplify the code and CSS a lot and even resizing.
And we could offer SVG and PNG export at the same time.

Only problem I'd have is:

@rugk
Copy link
Owner

rugk commented Apr 27, 2019

Actually qrcodegen.js also supports Canvas output out-of-the-box, so what is blocking this is really "just" the pixel-perfect rendering.

Thus asked for implementation.

Blocked by nayuki/QR-Code-generator#53

@rugk rugk added the blocked This issue is blocked by something from the outside and cannot be done currently. label Apr 27, 2019
@rugk
Copy link
Owner

rugk commented Apr 29, 2019

I've created a test page for all modes of the QR code libs we use, so that one can have a look whether they look all sharp and suitable: https://rugk.github.io/qr-code-libs-test/

See also discussion at nayuki/QR-Code-generator#53 (comment)

@rugk rugk reopened this May 23, 2019
@rugk
Copy link
Owner

rugk commented May 23, 2019

No need to close, this is still planned.

@rugk
Copy link
Owner

rugk commented May 25, 2019

Please stop trolling or I'll have to block you here. If you do not want to receive notifications, click the "unsubscribe" button. Do leave this issue open.

@rugk rugk reopened this May 25, 2019
@rugk
Copy link
Owner

rugk commented May 25, 2019

This is my repo and I will leave this issue open. As said, just click "unsubscribe" and it won't appear in your list.

@rugk rugk reopened this May 25, 2019
Repository owner locked as too heated and limited conversation to collaborators May 25, 2019
Repository owner unlocked this conversation May 30, 2019
@rugk rugk mentioned this issue Jul 29, 2019
Closed
@rugk rugk changed the title Drop kjua Combine SVG and Canvas generation method Jul 29, 2019
@rugk rugk self-assigned this Aug 1, 2019
@rugk rugk mentioned this issue Aug 1, 2019
Merged
@rugk rugk closed this as completed in d81b05a Oct 16, 2019
@rugk rugk added this to the next release milestone Oct 16, 2019
@rugk
Copy link
Owner

rugk commented Oct 16, 2019

So, finally fixed. So this issue is closed, as you like it… 😃

@fregante fregante changed the title Combine SVG and Canvas generation method . Feb 19, 2020
@rugk rugk changed the title . Combine SVG and Canvas generation method Mar 20, 2020
Repository owner locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked This issue is blocked by something from the outside and cannot be done currently.
Projects
None yet
Milestone
v1.7
Development

Successfully merging a pull request may close this issue.

Remove qrcodegen and replace with new kjua-svg version from @werthdavid rugk/offline-qr-code
2 participants
@fregante @rugk