-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow resizing via (Ctrl+)mousewheel + pinch-to-zoom #189
Comments
Hi, could I work on this? |
@eridilla Sure, you can. The UX needs some testing here, i.e. IÄm not sure what is most useful.
So I just tested the current state and while + and - key do not work (the last two points) - it just resizes the tab I have open, it seems that mouse wheel already works. It sometimes resizes the tab/website, too, but it certainly also zooms Maybe though:
Technically, you may experiment between:
Please also have a look at the ideas in #57 Firefox 105.0.2 (64-bit) on Linux/Fedora |
@rugk Hey, I have implemented the zoom function using the keyboard, but I thought that it's generally not a good idea to overwrite basic key binds like "Ctrl + plus/minus" and also when I tried, I haven't found a way that made it only zoom the extension and not the whole tab, so instead I made it so it listens to "Alt + plus/minus" and added a little tooltip for it. The zoom levels have a boundary too so the generated code doesn't move in the container and stays centered. The zoom also persists after reopening the extension like you mentioned in your reply. Regarding the pinch zoom, I don't have a means to test that function if I would work on it, so I haven't looked at that. I have made a pull request from my fork with my contributions. If you find any issues with what I wrote please let me know so I can learn as much as possible. |
by @bfred-it in #57 (comment)
That's especially useful for touch devices.
Maybe we can intercept the page zoom on Ctrl+scroll wheel, that currently "works" i.e. leads to:
The text was updated successfully, but these errors were encountered: