Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a menu to the popup #225

Open
jamescallumyoung opened this issue Oct 16, 2019 · 3 comments
Open

Add a menu to the popup #225

jamescallumyoung opened this issue Oct 16, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request usability/UX

Comments

@jamescallumyoung
Copy link

Background

In #213 we have discussed how we think a menu should be displayed so that extra features (in this case, special forms) can be added to the popup without cluttering the UI.

I'm proposing this separate feature request so we can keep the discussion about the menu here and keep #213 focused on the feature requested.

Proposed solution

Add a small button along the top of the popup window that opens up a menu. The menu will probably be best if it covers the whole popup as the window is pretty small.

Links to extra pages within the popup, and maybe other options, can then be added to the menu.

Alternatives

I originally suggested a "material" themed header and sidebar solution but @rugk suggested this might take up too much space on the small popup window.

Additional context

See #213 for the earlier conversation.

@jamescallumyoung jamescallumyoung added the enhancement New feature or request label Oct 16, 2019
@rugk
Copy link
Owner

rugk commented Oct 16, 2019

Indeed, good idea to open a new issue.

The menu will probably be best if it covers the whole popup as the window is pretty small.

I doubt so.

Did a quick mockup and I actually had a "show all options, hover over one and it shows the option" in my mind. This also solves the space problem a little, because you can only show an icon, when it it not hovered, and "expand" the option, if it is shown.

grafik

menuPopup.zip

(created with drawIo)

@jednomije
Copy link

I would like to handle this issue. I would add buttons for saving and copying the QR code like it was mentioned in the #267 issue.

@rugk
Copy link
Owner

rugk commented Oct 19, 2022

@jednomije You may give it a try, but please have a look at the previous discussion and the mockup/ideas. We need to come up with some clever UI that does not cover the QR code, but does not waste space, too.

(And sorry for the late reply, I was busy and missed the notification, sorry.)

@jednomije jednomije mentioned this issue Oct 31, 2022
@rugk rugk linked a pull request Dec 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request usability/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants