Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement (styling of) warning message #83

Closed
rugk opened this issue May 17, 2018 · 1 comment
Closed

Implement (styling of) warning message #83

rugk opened this issue May 17, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rugk
Copy link
Owner

rugk commented May 17, 2018

Currently I had no use for showing a warning message, but that may change.

In any case, I think, it is useful for the future.

The JS stuff is already implemented as far as I see (but test it, nevertheless!). It uses the element with id messageWarning for warning messages.

What needs to be done is:

  • look at how other messages are implemented/added and do it the same for the warning message
  • adhere to the design guide for message bars: https://design.firefox.com/photon/components/message-bars.html
  • test that thing with some warning message – maybe you even find a place, where it could be useful to add one
@rugk rugk added enhancement New feature or request good first issue Good for newcomers labels May 17, 2018
This was referenced May 17, 2018
Open
Closed
@rugk
Copy link
Owner Author

rugk commented May 31, 2018

Done in #86

@rugk rugk closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add warning for low contrast and equal colors
1 participant
@rugk