-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support forcing light style #5
Comments
I think this might be my bug. I've got the |
Yes, of course, it only can force the dark mode. So what is your concern here? |
I was falsely under the impression that it could toggle dark mode, regardless of whether I had it set by default or not. I'll just sit subscribe to this bug (and the Bugzilla one on the FF bug tracker) for updates. |
Yep, thanks. You'll see that the API(s) does not really allow this. I tried to make it very clear in the add-on description etc. that it actually is not possible to force a light style. (for many websites, at least, as likely no one uses |
I must have missed that description. I do have a peristent problem whereby I don't fully read the middle of sentences etc..... :P |
Hi, I have great news for you! According to my testing, the latest v2.0 release fixes this issue due to the way it now uses a completely new API to do "dark-mode-changing" "properly". For more information, please see the release notes. If the issue should not be fixed, please let me know. |
As explained in the Readme and in the descriptions etc. of AMO, we can only try to force websites to have a dark style.
We cannot force a light style, mostly, as most websites won't use
prefers-color-scheme: light
.The text was updated successfully, but these errors were encountered: