Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forcing light style #5

Closed
rugk opened this issue May 20, 2019 · 7 comments · Fixed by #41
Closed

Support forcing light style #5

rugk opened this issue May 20, 2019 · 7 comments · Fixed by #41
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rugk
Copy link
Owner

rugk commented May 20, 2019

As explained in the Readme and in the descriptions etc. of AMO, we can only try to force websites to have a dark style.

We cannot force a light style, mostly, as most websites won't use prefers-color-scheme: light.

@rugk rugk added enhancement New feature or request blocked This cannot be resolved, because it is blocked by some dependency or similar… labels May 20, 2019
@rugk
Copy link
Owner Author

rugk commented May 20, 2019

@sbrl
Copy link

sbrl commented Sep 16, 2019

I think this might be my bug. I've got the prefers-color-scheme: dark enabled via ui.systemUsesDarkTheme = 1 (I think that's the property name? I can't remember), so when I try to use this extension, nothing happens - since it can't unset the dark theme setting.

@rugk
Copy link
Owner Author

rugk commented Sep 16, 2019

Yes, of course, it only can force the dark mode. So what is your concern here?

@sbrl
Copy link

sbrl commented Sep 16, 2019

I was falsely under the impression that it could toggle dark mode, regardless of whether I had it set by default or not.

I'll just sit subscribe to this bug (and the Bugzilla one on the FF bug tracker) for updates.

@rugk
Copy link
Owner Author

rugk commented Sep 17, 2019

Yep, thanks. You'll see that the API(s) does not really allow this.

I tried to make it very clear in the add-on description etc. that it actually is not possible to force a light style. (for many websites, at least, as likely no one uses prefers-color-scheme: light on their site)

@sbrl
Copy link

sbrl commented Sep 17, 2019

I must have missed that description. I do have a peristent problem whereby I don't fully read the middle of sentences etc..... :P

@rugk rugk self-assigned this Nov 28, 2021
@rugk rugk removed the blocked This cannot be resolved, because it is blocked by some dependency or similar… label Nov 28, 2021
@rugk rugk closed this as completed in 6106115 Dec 7, 2021
@rugk rugk added this to the 2.0 milestone Dec 8, 2021
@rugk
Copy link
Owner Author

rugk commented Dec 8, 2021

Hi, I have great news for you! According to my testing, the latest v2.0 release fixes this issue due to the way it now uses a completely new API to do "dark-mode-changing" "properly". For more information, please see the release notes. If the issue should not be fixed, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants