Add --list-available-roles to print the list of roles available to assume and exit #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalbasit
commented
Apr 15, 2024
| @@ -97,7 +97,7 @@ const credentialsManager = new CredentialsManager(logger, argv.awsRegion, argv[' | |||
| await trash(paths.data); | |||
| } | |||
|
|
|||
| if (!argv.headful) { | |||
| if (!argv.headful && !argv.listAvailableRoles) { | |||
There was a problem hiding this comment.
Without adding this, the output looks something like this:
❯ node index.js --idp-id=redacted --sp-id=redacted --aws-region us-west-2 --list-available-roles
⠋ Logging inarn:aws:iam::1234567890:role/StagingAccount-AdministratorAccess
arn:aws:iam::1234567890:role/StagingAccount-FullReadOnlyAccess
arn:aws:iam::1234567890:role/StagingAccount-ReadOnlyAccess
arn:aws:iam::1234567891:role/ProductionAccount-AdministratorAccess
arn:aws:iam::1234567891:role/ProductionAccount-FullReadOnlyAccess
arn:aws:iam::1234567891:role/ProductionAccount-ReadOnlyAccess
I have to filter out stderr to get the output to look good
❯ node index.js --idp-id=redacted --sp-id=redacted --aws-region us-west-2 --list-available-roles 2>/dev/null
arn:aws:iam::1234567890:role/StagingAccount-AdministratorAccess
arn:aws:iam::1234567890:role/StagingAccount-FullReadOnlyAccess
arn:aws:iam::1234567890:role/StagingAccount-ReadOnlyAccess
arn:aws:iam::1234567891:role/ProductionAccount-AdministratorAccess
arn:aws:iam::1234567891:role/ProductionAccount-FullReadOnlyAccess
arn:aws:iam::1234567891:role/ProductionAccount-ReadOnlyAccess
Looking for recommendation on what's the best way to address this.
|
@ruimarinho Do you mind taking a look if this implementation is satisfactory to close #56? |
|
@ruimarinho any chance to get this merged, please?? |
kalbasit
added a commit
to canary-technologies-corp/homebrew-tap
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
gsts ... --list-available-rolesprints the list of available roles and exits. Also, if-o jsonwas given, the list of roles is then printed in JSON.Please scrutinize my PR, I'm neither a TypeScript expert nor I know gsts internally well.
closes #56