Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to see you add the capability to pull ebay auction details combined with snipe #1

Open
bthome opened this issue Jun 11, 2016 · 5 comments

Comments

@bthome
Copy link

bthome commented Jun 11, 2016

Just came across your server\library and excited to try and use it. Creating a dashboard to monitor my activities and would like a little help \ enhancement that would make it easier to use.

Help: Any way to combine the /snipes and /auctions/auctionID/ into one json response?

Enhancement:

  1. Add a GET that pulls all the details from ebay for all the snipes. Providing one JSON object per snipe that has the combined information.
  2. Add a DELETE that will delete all snipes that have ended in X hours\days.
@ruippeixotog
Copy link
Owner

Hi @bthome!

The DELETE endpoint you mentioned seems useful and can be easily implemented (if you're referring to the snipe time, not to the auction ending time).

Regarding your GET suggestion, I'm a bit concerned with the quantity of requests to eBay calling such an endpoint would generate. While this server provides users an easy way to retrieve that information programmatically, I'd like to avoid having endpoints that generate a high number of requests in a short period of time. Ultimately, I suppose it can lead to account bans.

One partial solution would be to store/cache some information about the auction (for example item name, seller, thumbnail) when a snipe is scheduled. It wouldn't show the latest bid and bit count, though.

@bthome
Copy link
Author

bthome commented Jun 18, 2016

The snipe appears to disappear after the auction completes. Would like to keep the snipe so my dashboard can show that it did complete and if I won \ lost the bid. It would be an enhancement to show the status of the snipe (i.e. submit time, success or failure). The DELETE would be used to provide a means to delete old snipes. Snipes would need to be persisted until they were deleted or when you POST you could set the time to live.

The GET (which I simulated in a script) could be implemented in a way that regardless of when you call it the data would be cached (minimum 5 minutes) to avoid excessive calls to ebay. When you get within 5 minutes of the snipe\auction close then you would process the request without the cache limit.

Thank you for the library. I have implemented the Docker version and it saves me from having to download a fat client to my desktop.

@AnthonyVH
Copy link

@bthome Is your dashboard code available somewhere?

@lucasbento
Copy link

@bthome Is your dashboard code available somewhere?

Same question, really interested on it.

@Helvio88
Copy link

Helvio88 commented Jan 4, 2019

@bthome Is your dashboard code available somewhere?

I have created an Angular dashboard:
https://github.com/Helvio88/ebay-snipe-frontend

Hope it helps!
@ruippeixotog let me know if you want work with me to implement it in your Docker solution so we don't have to deal with Reverse Proxying. I sent you a Hangouts message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants