Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS rules don't work with latest protobuf (3.21.x) repo #212

Closed
srabraham opened this issue Aug 11, 2022 · 3 comments · Fixed by #178
Closed

JS rules don't work with latest protobuf (3.21.x) repo #212

srabraham opened this issue Aug 11, 2022 · 3 comments · Fixed by #178
Labels
bug Something isn't working lang-js JavaScript rules specific resolved-next-release Code to resolve issue is pending release

Comments

@srabraham
Copy link

Description

For some unknown reason, Google removed JavaScript support from the core protocolbuffers repo: protocolbuffers/protobuf#9874

This makes rules_proto_grpc unable to generate JavaScript protos. The correct new way to do things is to bring in https://github.com/protocolbuffers/protobuf-javascript and use it as a plugin to protoc.

The error I get currently with a rules_proto_grpc JS target is: "protoc-gen-js: program not found or is not executable"

Thanks for your work on this, Adam!

@alexeagle FYI

@srabraham
Copy link
Author

@aaliddell aaliddell added bug Something isn't working lang-js JavaScript rules specific labels Aug 23, 2022
@aaliddell
Copy link
Member

Thanks for the pointers on this, this is adopted in #178

@aaliddell aaliddell added the resolved-next-release Code to resolve issue is pending release label Aug 23, 2022
@srabraham
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lang-js JavaScript rules specific resolved-next-release Code to resolve issue is pending release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants