Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new architecture #243

Open
tarkcelk opened this issue Mar 21, 2023 · 4 comments
Open

Support for new architecture #243

tarkcelk opened this issue Mar 21, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@tarkcelk
Copy link

Describe the bug
Pdf package doesn't work when build a project with new architecture enabled, need to update the package to be compatible.

To Reproduce

  • Create a react native project with latest version (My case was 0.71.4)
  • Enable the new architecture.
  • Install this package and build the project.
  • Render a pdf and see the fabric incompatibility warning.

Steps to reproduce the behavior:

  1. Render PDF with any kind of resource.
  2. See the fabric incompatibility warning

Expected behavior
Proper rendering when new architecture is enabled.

Screenshots
Screenshot_1679408336

Smartphone (please complete the following information):

  • Device: Pixel 2 , iPhone 13
  • OS: Android, iOS
  • Version API 29, iOS 16.0
@rumax
Copy link
Owner

rumax commented Mar 27, 2023

Hi @tarkcelk, new new architecture is still experimental, right?

This documentation is still experimental and details are subject to changes as we iterate.

@rumax rumax added the enhancement New feature or request label Mar 27, 2023
@stale
Copy link

stale bot commented May 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 15, 2023
@mrshahzeb7
Copy link

Now you can use the "New Renderer Interop Layer"
The interop layer is shipped with React Native 0.72

Just add a component name like this in react-native.config.js

module.exports = {
project:{
android: {
unstable_reactLegacyComponentNames: [ "PDFView" ]
},
ios: {
unstable_reactLegacyComponentNames: [ "PDFView" ]
}
},
};

"The interop layer is a feature that lets you reuse legacy Native Components in New Architecture apps"

Read More
https://github.com/reactwg/react-native-new-architecture/discussions/135

@stale stale bot removed the wontfix This will not be worked on label Oct 2, 2023
@tarkcelk
Copy link
Author

@mrshahzeb7 thanks, i will be looking to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants