Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGVectorStore should use pooled connection #1159

Closed
ryanleecode opened this issue Sep 7, 2024 · 0 comments · Fixed by #1175
Closed

PGVectorStore should use pooled connection #1159

ryanleecode opened this issue Sep 7, 2024 · 0 comments · Fixed by #1175
Labels
enhancement New feature or request

Comments

@ryanleecode
Copy link
Contributor

The db in PGVectorStore is a singleton. We should use a Pool instead of Client otherwise eventually you will get disconnected.

https://github.com/run-llama/LlamaIndexTS/blob/main/packages/llamaindex/src/storage/vectorStore/PGVectorStore.ts#L96
@himself65 himself65 added the enhancement New feature or request label Sep 9, 2024
@himself65 himself65 mentioned this issue Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: vector store cleanup himself65/LlamaIndexTS
2 participants
@himself65 @ryanleecode