Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-gitlab version >= 0.29.0 #1142

Closed
LAKostis opened this issue Aug 6, 2020 · 3 comments · Fixed by #1144
Closed

update go-gitlab version >= 0.29.0 #1142

LAKostis opened this issue Aug 6, 2020 · 3 comments · Fixed by #1144

Comments

@LAKostis
Copy link

LAKostis commented Aug 6, 2020

go-gitlab bundled with atlantis is very outdated and doesn't work very well with V4 API. Sometimes gitlab server could reply with error 500 and request should retry but this behavior was implemented only in version 0.29.0 (xanzy/go-gitlab#800)

Currently, our atlantis losing POST data and won't return anything back on apply command which causing problems with CI usage.

Cheers

@LAKostis
Copy link
Author

LAKostis commented Aug 6, 2020

Example error with current version:

2020/08/05 16:00:28+0000 [EROR] command_runner.go:426 xxxxxxxx: Unable to comment: POST https://gitlab.com/api/v4/projects/xxxxxxx/notes: 500 {message: 500 Internal Server Error}

@lkysow
Copy link
Member

lkysow commented Aug 6, 2020

@LAKostis can you try with runatlantis/atlantis:latest? I've merged the update PR.

@LAKostis
Copy link
Author

@lkysow sorry, was busy last week. Tested :latest changes in our projects, no regressions observed. Haven't seen 500 errors from gitlab either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants