Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlantis approve_policies creates a pending check #1797

Closed
ninjahck opened this issue Sep 8, 2021 · 5 comments
Closed

Atlantis approve_policies creates a pending check #1797

ninjahck opened this issue Sep 8, 2021 · 5 comments
Labels
bug Something isn't working waiting-on-response Waiting for a response from the user

Comments

@ninjahck
Copy link

ninjahck commented Sep 8, 2021

Overview of the Issue

As during the use it's been discovered that when we write atlantis approve_policies in the comment it creates a pending check : Pending — Approve_policies in progress. Although it sends a comment saying Approved policies for 1 projects and allow user to run atlantis apply but atlantis approve policies always seems to in progress state.

Now it remains in progress state , it has been noticed that if that happens and approve_policies may have allowed you to apply in the pr but let’s say you haven’t deleted the branch and created a new pr on the same branch so if the new pr has that commit where approve stage is pending , as due to approve_policies has made changes at global as apply_requirements: [policies_passed] which will result policies not being checked at new pr

Reproduction Steps

Environment details

Running as a docker custom image

  • Atlantis version: FROM runatlantis/atlantis:latest
  • Conftest Version: 0.25
@ninjahck ninjahck added the bug Something isn't working label Sep 8, 2021
@msarvar
Copy link
Contributor

msarvar commented Sep 9, 2021

Hey @ninjahck that should be fixed in the version 0.17.0, here is the PR that fixes it #1672. It might be that your atlantis version is not the latest?

@ninjahck
Copy link
Author

ninjahck commented Sep 9, 2021

As mentioned I am using the dockerfile : FROM runatlantis/atlantis:latest, I imagine this line must take the latest version right ?

@msarvar
Copy link
Contributor

msarvar commented Sep 9, 2021

Can you try to point to specific version? I'm not sure how your deploy process works, maybe it is caching your docker image?

@ninjahck
Copy link
Author

Yes I am using v0.17.3

@jamengual
Copy link
Contributor

is this still an issue with v0.19.8?

@jamengual jamengual added the waiting-on-response Waiting for a response from the user label Aug 26, 2022
@github-actions github-actions bot added the Stale label Oct 23, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2022
@nitrocode nitrocode reopened this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting-on-response Waiting for a response from the user
Projects
None yet
Development

No branches or pull requests

4 participants