Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If workspace is locked, message should say due to cmd running for which commit sha #303

Open
jolexa opened this issue Oct 1, 2018 · 1 comment
Labels
feature New functionality/enhancement help wanted Good feature for contributors

Comments

@jolexa
Copy link
Contributor

jolexa commented Oct 1, 2018

Hello,
This is an interesting user experience. In this case, the plan had an error and exit 1, at that point the tf code was fixed and then the next atlantis plan (autoplan) started running. Since the EC2 API has been degraded most of the day, a plan was running for a very long time. Then, we tried to manually run plan and got the workspace is locked message even though we have no way to fix it.
image

So, a few things here to think about:

  1. Atlantis can send messages out of order. It might be nice to say, "another plan is running for commit $hash"
  2. Maybe a timeout option is needed?
@majormoses
Copy link
Contributor

Ya that makes sense to have some kind of "pointer", normally I think a git sha would be a good idea but I think that could be misleading with #427 which will rebase in additional changes but not commit them back to the remote. While the the "pointer" would still be right from a user traceability stance it is misleading because it's actually executing against different code from what you have in that branch. I suppose that could be OK as long as it's documented or stated in the comment itself about that behavior.

Maybe a timeout option is needed?

I think that needs to be a different discussion on wanting to implement timeouts, it would affect a lot of workflows for example that have RDS creations which can last 40 minutes or longer.

One thought I had was once we implement #305 which would solve the problem I think and is something that most CI providers support. Applies would be a bit different because aborting an apply is not currently safe per #187

@lkysow lkysow added the feature New functionality/enhancement label Apr 4, 2019
@lkysow lkysow changed the title Degraded EC2 API exposes a poor user experience (v0.4.10) If workspace is locked, message should say due to cmd running for which commit sha Apr 4, 2019
@chenrui333 chenrui333 added the help wanted Good feature for contributors label Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement help wanted Good feature for contributors
Projects
None yet
Development

No branches or pull requests

4 participants